jkesselm commented on code in PR #106: URL: https://github.com/apache/xalan-java/pull/106#discussion_r1367357827
########## .github/workflows/main.yml: ########## @@ -0,0 +1,51 @@ +name: CI + +on: + push: + branches: + - '*' + pull_request: + branches: + - '*' + +permissions: + contents: read + +# https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners +# GitHub Actions does not support Docker, PostgreSQL server on Windows, macOS :( + +concurrency: + # On master/release, we don't want any jobs cancelled so the sha is used to name the group + # On PR branches, we cancel the job if new commits are pushed + # More info: https://stackoverflow.com/a/68422069/253468 + group: ${{ github.ref == 'refs/heads/trunk' && format('ci-main-{0}', github.sha) || format('ci-main-{0}', github.ref) }} + cancel-in-progress: true + +jobs: + build: + name: 'Java 8' + runs-on: ubuntu-latest + steps: + - name: 'Checkout xalan-java' + uses: actions/checkout@v3 + - name: 'Set up JDK 8' + uses: actions/setup-java@v2 + with: + distribution: zulu + java-version: 8 + - name: 'Build Xalan jars' + run: | + ant jar + - uses: actions/checkout@v3 + name: 'Checkout xalan-test' + with: + repository: apache/xalan-test + path: xalan-test + ref: xalan-j_2_7_x + - name: 'Run xalan-test tests' + working-directory: xalan-test Review Comment: > This looks like checking out `xalan-test` as a subdirectory of `xalan-java`, while the build script is expecting it to be a sibling directory: Actually, tests can be run from either location. But fulldist wants it as a sibling unless the parameter is used to specify otherwise. Unfortunately the CI system didn't like me checking out into Xalan's parent directory. But it was willing to let me check out locally and then _move_ the tests up to a sibling position. Since I didn't discover the fulldist requirement until after I'd gotten past test, the yaml script currently checks out xalan-test as a child, runs the tests from there, then moves it up to sibling before running fulldist. This may not be the most self-evident approach, and the yaml script now has a comment explaining this. Yes, setting test.relpath was probably at least as clean. But I wanted fulldist to replicate the environment we use for our own production builds. And yes, we could try the mv workaround earlier rather than having test in different places at different times. "Make it work, make it good, make it great. It now demonstrably works. Clean up can be left as technical debt, though I'd give it low priority since this will change somewhat if test is brought into the main Xalan tree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
