vlsi commented on code in PR #106: URL: https://github.com/apache/xalan-java/pull/106#discussion_r1364945789
########## .github/workflows/main.yml: ########## @@ -0,0 +1,51 @@ +name: CI + +on: + push: + branches: + - '*' + pull_request: + branches: + - '*' + +permissions: + contents: read + +# https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners +# GitHub Actions does not support Docker, PostgreSQL server on Windows, macOS :( + +concurrency: + # On master/release, we don't want any jobs cancelled so the sha is used to name the group + # On PR branches, we cancel the job if new commits are pushed + # More info: https://stackoverflow.com/a/68422069/253468 + group: ${{ github.ref == 'refs/heads/trunk' && format('ci-main-{0}', github.sha) || format('ci-main-{0}', github.ref) }} + cancel-in-progress: true + +jobs: + build: + name: 'Java 8' + runs-on: ubuntu-latest + steps: + - name: 'Checkout xalan-java' + uses: actions/checkout@v3 + - name: 'Set up JDK 8' + uses: actions/setup-java@v2 + with: + distribution: zulu + java-version: 8 + - name: 'Build Xalan jars' + run: | + ant jar + - uses: actions/checkout@v3 + name: 'Checkout xalan-test' + with: + repository: apache/xalan-test + path: xalan-test + ref: xalan-j_2_7_x + - name: 'Run xalan-test tests' + working-directory: xalan-test Review Comment: @stanio, @jkesselm, if you feel confident, please fix it. I provided the major part of the CI scripts, and I expect adjusting the command should be trivial for committers/PMCs as I assume they use tests. I do not want spend my time on reverse-engineering scripts that will be deleted soon (both ant and xalan-test) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
