>While Joseph is to blame for not thoroughly verifying your contribution, >it seems you haven verified it enough as well. I think you're being >just unhelpful here.
Stanimir, correct me if I am wrong, however, I never blamed Joseph for "not testing PR before merge". If it fails, fine then, let's someone fix that. It should not be a problem. The lack of CI is a problem. A failing CI is much better than a non-existent one. I truly believe Joseph or someone from committers/PMC should be able to fix the failure in 5 minutes. It must be something like "missing property" or "wrong xalan-test branch" or something like that. I truly do not like spending my time deciphering existing xalan-java and xalan-test build scripts, especially taking into account that "ant build scripts" will be gone soon. >it seems you haven verified it enough as well I was never able to launch Xalan tests as the setup was too complicated. I expect PMC to know the way to launch tests, so I suggest they should share the knowledge in the form of a CI configuration that everybody can use. I provided all the major bits in PR#9. The only missing bit was a one-line commit from a committer who knows how to launch tests. It was impractical for me to spend hours trying to launch it. >I think you're being just unhelpful here. I beg your pardon, I thought providing scripts for CI was helpful. You asked me (with an explicit mention) if I care to "provide a fix for your original contribution" in https://github.com/apache/xalan-java/pull/106#discussion_r1364865241, and I sincerely answered that I did not want to do that because I did not want to spend time on "reverse-engineering scripts that will be deleted soon (both ant and xalan-test)". As many years before (see https://github.com/apache/xalan-java/pull/2#issuecomment-1194036112 ), I can easily migrate the script to Gradle if you like that better. The codebase is trivial, and it should be testable with a single command like "./gradlew test" I believe all of that (CI scripts, sincere answers, and a suggestion for refactoring the build scripts) is helpful, so please let me know why do you think my suggestions and comments are not helpful. It would help me become more helpful the next time. Vladimir
