vlsi commented on PR #108:
URL: https://github.com/apache/xalan-java/pull/108#issuecomment-1774593498

   @mukulga , this PR brings "Eclipse Public License" source dependency which 
is forbidden by the ASF rules.
   
   >https://www.apache.org/legal/resolved.html#binary-only-inclusion-condition
   > Do not include Category B licensed works in source releases.
   
   ---
   
   @mukulga , could you please stop creating immediately closing PRs?
   
   Creating a PR like that adds no value, and it does clutter "pull requests" 
tab on GitHub.
   
   Please use concise wording. The title of the current PR is "committing 
enhancements to xs:dateTime data type's implementation, and adding a few new 
working test cases for xs:dateTime data type's arithmetic. also modifying the 
NOTICE.txt file, mentioning details of a few implementation dependencies for 
this xalanj dev repos branch." which is unreasonably long.
   Please take your time to summarize the change in  50-100 characters.
   
   For instance,
   * Stop using "committing enhancements" words. They literally add no value 
since, well, you make a commitment. Why duplicate that by saying "committing"?
   * Move non-important data to the body rather than putting everything into 
the subject. Compare it with email: you should not put the full message into 
the subject line, and you should keep the subject short, and then you elaborate 
in the body. The same goes with commit messages: you put a short summary in the 
subject line, then you add a blank line, and then you put everything else.
   * "adding few new working test cases" -- it is absolutely not needed for the 
subject line. Of course you added tests. Why putting an emphasis on that?
   * "mentioning details of few implementation dependencies for this xalanj dev 
repos branch" this does not belong to the subject line as well
   
   
   If you struggle with identifying what could be the proper commit message, 
assume you format an email:
   
   ```
   SUBJECT
   
   BODY
   ```
   
   Then format your commit message **in the same way**
   
   ```
   COMMIT HEADLINE (the most important information, like SUBJECT in email)
   
   BODY (details)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org

Reply via email to