vlsi commented on PR #108:
URL: https://github.com/apache/xalan-java/pull/108#issuecomment-1775023049
> helps to have a XalanJ process already setup as of now for non-committers
to be able to make their codebase contributions to XalanJ
Committers already have an infrastructure: they can commit to a branch
directly.
If you commit directly, it is less actions for everybody:
* less commits: no "merge" commits in history
* less notification noise for everybody: no "pr created and immediately
closed" notifications
* less work for committers: they can just commit code instead of "commit
code + create PR + merge PR"
>Definitely not, please.
Could you please clarify why you deviate from the Git recommendation then?
https://git-scm.com/docs/git-commit#_discussion
> Git commit man page: It’s a good idea to begin the commit message with a
single short (less than 50 character) line summarizing the change, followed by
a **blank line** and then a more thorough description.
> mukulga: Shortening the PR title, of a complicated code change, and not
mentioning needed details on PR title, shall make it difficult for users to
start reviewing the code changes of the PR
Please read `git-commit#_discussion` carefully. I do not suggest removing
details.
I suggest using "subject" and "body" better: put the most important bits
into **subject**, and put details in **body**. They should be separated by a
blank line as per Git conventions.
It is not something I invented. It is a generic Git recommendation.
Do you think you could format commit messages into the subject line and the
body?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
