mukulga commented on PR #108: URL: https://github.com/apache/xalan-java/pull/108#issuecomment-1774846559
@vlsi, Thanks for pointing to this issue. Here's what I think, as of now with respect to this topic, As mentioned within the NOTICE.txt file that we've modified yesterday on XalanJ's dev repos branch xalan-j_xslt3.0, we're using little bit (I guess, appx 0.1% or even lesser) of codebase (we're not using exact copies of the code files, but we're using few algorithm outlines which is not very much practicle to provide in software binary form within this XalanJ work) from Eclipse WTP project's XPath 2.0 processor (ref, https://projects.eclipse.org/projects/webtools). Apache XercesJ (for the XML Schema 1.1 version) also includes, Eclipse WTP project's XPath 2.0 processor jar file. The XercesJ team (including me :)), wrote many codebase improvements (we did not modify the core design or codebase of WTP's XPath 2.0 processor, but we solved various bugs bringing this XPath 2.0 processor's W3C XPath 2.0 test suite's compliance from appx 40% to near 100%) for Eclipse WTP project's XPath 2.0 processor. We hope to elaborate more, and to comply more correctly, with the portions of codebase from "Eclipse WTP project's XPath 2.0 processor" that we're using, before we'll make a public release of XalanJ's XSLT 3.0 and XPath 3.1 implementation work. For now, we need to use few of the Eclipse WTP XPath 2.0 processor's code algorithm patterns, to make progress on XalanJ's XSLT 3.0 and XPath 3.1 implementation development. > could you please stop creating immediately closing PRs? > Creating a PR like that adds no value, and it does clutter "pull requests" tab on GitHub. As I wrote within another XalanJ discussion thread 2-3 days ago to your question, about this same topic, for our reasons of creating PRs and merging them early by me as in this case. IHMO, I'm a XalanJ committer and I may commit code and merge that myself however quickly (my intention is never to inconvenience anyone on this list with the contents and frequency of my PRs). Any other XalanJ committer or a pmc member, can raise any concerns and objections to the PRs and the git merges that I'm doing on these PRs, and then I shall be bound to accept those points. Also any product like XalanJ, that's in a midst of these development activities these days, is bound to have significant mail traffic. This is due to the work that we're doing, and not because we wish to inconvenience anyone. > Please use concise wording. The title of the current PR is ... I think, the PRs titles that we're using, need to convey as much as possible the purpose of the PR. Shortening the PR title, of a complicated code change, and not mentioning needed details on PR title, shall make it difficult for users to start reviewing the code changes of the PR. Deciding on this, is again I feel, is a prerogative of the project committer. IMHO, the PRs functional code contribution or a bug fix is important, than the text of the PR title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
