jkesselm commented on PR #130:
URL: https://github.com/apache/xalan-java/pull/130#issuecomment-1828159843

   You removed "site" from the build script.  Remember that our "binary 
distributions" zipfiles need to include the documentation. AFAICT, that means 
site must occur before package produces the latter, which is why that order is 
specified in the script.
   
   We *could* move the operations now performed in site into a phase run before 
package. (prepackage?). Or move generating the distribution files from package 
into a later one ("install" doesn't seem entirely right, but seems to come 
closest). Neither seems to be wholly appropriate in Maven idiom, which seems to 
assume site is orthogonal to other builds. 
   
   Can we fix this? If not, the mvnbuild scripts need to be left unchanged for 
now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org

Reply via email to