jkesselm commented on PR #130: URL: https://github.com/apache/xalan-java/pull/130#issuecomment-1829076570
> If a goal or phase in lifecycle A needs another one in lifecycle B, this is a smell. You're right, I misread. Apologies. It was tired and I was late. The choice to put Javadoc in site was based on examples I found online. It certainly may be absolutely the Wrong Thing for our needs. If I move that and the other document processing into the main flow, would compile be the recommended phase, or something else? It is, arguably, a kind of compilation... I'd have to make those depend upon the taglet module, but that's certainly doable. Site being a separate flow makes some sense. The problem is the established pattern that the binary distribution has included both a copy of the code and a local copy of the website, to make it a single-download "product" image. We don't _have_ to continue that pattern, if course; site can do its own "packaging" into a separate docs zip file. I was trying to produce "the same" zipfile content, but may have to give up - that goal and settle for equivalent. (As agreed, I'm staying out of your way as much as possible. I'm currently focusing on making xalan-test play nice with the Maven build. The generated lib/ directory isn't quite making it happy yet, but that's probably over-specific jarfile references that should be fixed from test's end of things. Once that's resolved I'm planning to remove the bootclasspath kluge.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
