kriegaex commented on PR #130: URL: https://github.com/apache/xalan-java/pull/130#issuecomment-1829010253
> You removed "site" from the build script. No, I did not. I reckon it is late at your location, maybe your eyes are just a bit tired. Please check again. I removed `compile`, because executing `package`, as explained in the commit comment, implies `compile` already. Then I simply changed the order of `package` and `site`, which should not be a problem, because they are in different build lifecycles, as I also explained. Building a Maven site is a separate lyifecycle from building and packaging the product itself. I.e., if you just run `mvn site`, you should get a complete Maven site. If you just run `mvn package`, you should get a correctly packaged product. If a goal or phase in lifecycle A needs another one in lifecycle B, this is a smell. In our case here, if you can only successfully package after building a site, this is an error in the build configuration, because building a site is optional and therefore not part of the default lifecycle. Like I mentioned in another discussion before, each module should create its own javadocs, because the latter are needed per module to pass Maven Central upload checks anyway. If, like in this case, you want aggregated javadocs across all modules on top per-module ones and include them in the binary distro, this should be done in the build lifecycle, not in the site lifecycle (or in both, if you need it in both!). And you are right, creating javadocs needs to happen before creating the binary distro assembly, of course. Funny detail: No matter if I run `mvn clean package site` or `mvn clean site package`, I noticed that the site (and with it the javadocs) is always generated before the assembly plugin runs, i.e. in both cases the binary distro contains the site, just as you envision. Actually, that surprises me. I would have thought that the site is created later. But because I would not rely on such behaviour, for now I understand that you reversed the order in your add-on commit to `mvn clean site package`. The real fix for that build config should get its own PR. Another question I have is, whether you really want the full Maven site packaged into the binary distroor really just aggregated javadocs. Presently, the former happens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
