[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on issue #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it

[GitBox]

yangwwei commented on issue #81: [YUNIKORN-28] Support validating 
yunikorn-configs before admitting it
URL: 
https://github.com/apache/incubator-yunikorn-k8shim/pull/81#issuecomment-601409572
 
 
   Two issues while testing this out:
   
   1) It seems the admission-controller service somehow has linked to the 
yunikorn-scheduler pod. This is not correct. Is this because of the 
`matchedLabel` used?
   
   <img width="1647" 
alt="yunikorn-admission-controller-service_-_Kubernetes_Dashboard" 
src="https://user-images.githubusercontent.com/14214570/77112003-7e8fc500-69e5-11ea-82f8-b412cfb677a2.png";>
   
   2) In `admission_controller.go#validateConf()`, it seems the http connection 
opened but not closed. Could you please make sure that is done as well.
   
   3) When I try this out, I got a warning event:
   
   ```
   7m25s       Warning   FailedToCreateEndpoint   endpoints/yunikorn-service    
                        Failed to create endpoint for service 
default/yunikorn-service: endpoints "yunikorn-service" already exists
   ``` 
   did you see this on your deployment?
   
   Please help to take look at these issues. Thx

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org