TaoYang526 commented on issue #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#issuecomment-601557543 @yangwwei Thanks for the review, replies as following: 1. Yes, I think so. But it can works as well since it restricts the target port to `webhook-api`. It's better to support role labels, we can correct the selector like this: `app: yunikorn && role: admission-controller` 2. Good catch, I forgot to close it, will be corrected soon. 3. No, have you checked if the scheduler pod works well? and is there any detailed logs?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
