wilfred-s commented on a change in pull request #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#discussion_r396895502
########## File path: deployments/admission-controllers/scheduler/README.md ########## @@ -56,6 +59,28 @@ kubectl get pod task0 -o yaml you'll see the `schedulerName` has been injected with value `yunikorn`. +#### Validations + +YuniKorn loads its configuration from a configmap called yunikorn-configs, this admission controller adds a web-hook to +validate the update and create requests for this configmap. +It is a safeguard to protect the scheduler not to load invalid configuration, by rejecting such requests. Review comment: Can we rephrase this to clearly explain the limits of what we have now: This validation rejects invalid configuration which otherwise would have been rejected inside the scheduler update process. Validations are currently limited to a syntax check only. The scheduler could still reject a configuration if it cannot replace the current configuration due to conflicts. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
