Reamer commented on a change in pull request #3769: URL: https://github.com/apache/zeppelin/pull/3769#discussion_r434543944
########## File path: scripts/docker/zeppelin-server/Dockerfile ########## @@ -0,0 +1,93 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +FROM zeppelin-distribution:latest AS zeppelin-distribution + +FROM alpine:3.11 AS downloader + +ENV TINI_VERSION=v0.19.0 + +RUN set -ex && \ + /sbin/apk add --no-cache wget gnupg + # Install tini +RUN set -ex && \ + /usr/bin/wget -q https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-static-amd64 -O /sbin/tini && \ + /usr/bin/wget -q https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini-static-amd64.asc -O /tmp/tini.asc && \ + /usr/bin/gpg --batch --keyserver keyserver.ubuntu.com --recv-keys 595E85A6B1B4779EA4DAAEC70B588DFF0527A9B7 && \ + /usr/bin/gpg --batch --verify /tmp/tini.asc /sbin/tini && \ + /bin/chmod +x /sbin/tini && \ + /bin/rm -v /tmp/tini.asc + +FROM ubuntu:18.04 +LABEL maintainer="Apache Software Foundation <dev@zeppelin.apache.org>" + +RUN set -ex && \ + apt-get -y update && \ + # Install language and other base packages + DEBIAN_FRONTEND=noninteractive apt-get install -y language-pack-en openjdk-8-jre-headless wget apt-transport-https gnupg && \ + apt-key adv --fetch-keys https://packages.cloud.google.com/apt/doc/apt-key.gpg && \ + echo "deb https://apt.kubernetes.io/ kubernetes-xenial main" | tee -a /etc/apt/sources.list.d/kubernetes.list && \ + DEBIAN_FRONTEND=noninteractive apt-get -y update && \ + DEBIAN_FRONTEND=noninteractive apt-get install -y kubectl && \ + # Cleanup + rm -rf /var/lib/apt/lists/* && \ + apt-get autoclean && \ + apt-get clean + +ARG version="0.9.0-SNAPSHOT" + +ENV LANG=en_US.UTF-8 \ + LC_ALL=en_US.UTF-8 \ + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 \ + VERSION="${version}" \ + Z_HOME="/opt/zeppelin" \ + ZEPPELIN_ADDR="0.0.0.0" \ + ZEPPELIN_WAR_TEMPDIR="/tmp/webapps" \ + ZEPPELIN_DEP_LOCALREPO="/tmp/local-repo" + +# Copy Zeppelin related files +COPY --from=zeppelin-distribution /opt/zeppelin/zeppelin-web-${VERSION}.war ${Z_HOME}/ +COPY --from=zeppelin-distribution /opt/zeppelin/zeppelin-web-angular-${VERSION}.war ${Z_HOME}/ +COPY --from=zeppelin-distribution /opt/zeppelin/conf ${Z_HOME}/conf +COPY --from=zeppelin-distribution /opt/zeppelin/bin ${Z_HOME}/bin +COPY --from=zeppelin-distribution /opt/zeppelin/lib ${Z_HOME}/lib +COPY --from=zeppelin-distribution /opt/zeppelin/plugins ${Z_HOME}/plugins +COPY --from=zeppelin-distribution /opt/zeppelin/interpreter/zeppelin-interpreter-shaded-${VERSION}.jar ${Z_HOME}/interpreter/zeppelin-interpreter-shaded-${VERSION}.jar +# copy example notebooks +COPY --from=zeppelin-distribution /opt/zeppelin/notebook ${Z_HOME}/notebook +# copy k8s files +COPY --from=zeppelin-distribution /opt/zeppelin/k8s ${Z_HOME}/k8s +# Copy interpreter-settings for activate interpreter +# COPY --from=zeppelin-distribution /opt/zeppelin/interpreter/spark/interpreter-setting.json ${Z_HOME}/interpreter/spark/interpreter-setting.json +# COPY --from=zeppelin-distribution /opt/zeppelin/interpreter/jdbc/interpreter-setting.json ${Z_HOME}/interpreter/jdbc/interpreter-setting.json +# COPY --from=zeppelin-distribution /opt/zeppelin/interpreter/md/interpreter-setting.json ${Z_HOME}/interpreter/md/interpreter-setting.json Review comment: It depends, how much images should be maintained by the Zeppelin project. In my opinion Zeppelin should show the way how to extend a image. Zeppelin should only maintain a small set of interpreter. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
