Reamer commented on a change in pull request #3769:
URL: https://github.com/apache/zeppelin/pull/3769#discussion_r434610135



##########
File path: k8s/zeppelin-server.yaml
##########
@@ -115,7 +115,7 @@ spec:
             path: nginx.conf
       containers:
       - name: zeppelin-server
-        image: apache/zeppelin:0.9.0-SNAPSHOT
+        image: apache/zeppelin-server:0.9.0-SNAPSHOT

Review comment:
       > one image is more handy to work with
   
   You are right, one or at least a small set of images is more practical for 
work. In fact, I currently have only three images (distribution image, server, 
(one large) interpreter image) in my K8s setup.
   
   The title of ZEPPELIN-4154 and the first PR #3380 imply an image for each 
interpreter. This PR tries to solve the task.
   
   In my opinion we should at least provide different images for the Zeppelin 
server and the Zeppelin interpreter. A distribution image is useful to build 
Zeppelin only once and copy the same version to the Zeppelin server and the 
Zeppelin interpreter. 
   
   My main goal for different images is to reduce the size and start time of 
images in a container cluster.
   The size of my current Zeppelin image is only 410.95MB. The download and 
total startup time of the new instance is short.
   My Zeppelin interpreter image is quite large (1.53 GB). The download time is 
quite long.
   
   If we want to create an image for each interpreter, the image size is 
reduced. All interpreter images should use the same base image to benefit from 
a potentially available layer.
   
   > How it all will work on non-K8S? Like, using Docker just for not 
installing anything to machine
   
   Docker is also able to set up a local network, in most cases this is done 
via a [bridge network](https://docs.docker.com/network/bridge/). The Zeppelin 
server needs access to create/modify the network via the Docker daemon's tcp 
interface or at least the information when new containers are created via the 
tcp interface.
   In my opinion, a docker cluster via a docker swarm should not fall within 
the scope of this project.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to