Reamer commented on a change in pull request #3785:
URL: https://github.com/apache/zeppelin/pull/3785#discussion_r435066518
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterRunningProcess.java
##########
@@ -80,6 +88,10 @@ public Void call(RemoteInterpreterService.Client client)
throws Exception {
} catch (Exception e) {
logger.warn("ignore the exception when shutting down interpreter
process.", e);
}
+
+ // Shutdown connection
+ shutdown();
+ logger.info("Remote process of interpreter group: " +
getInterpreterGroupId() + " is terminated");
Review comment:
Could you please make the logger 'public static final' and avoid the
creation of objects if the logger is disabled for the INFO level (
`LOGGER.info(String format, Object... arguments);`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
