Reamer commented on a change in pull request #3785:
URL: https://github.com/apache/zeppelin/pull/3785#discussion_r435142920
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterManagedProcess.java
##########
@@ -141,7 +141,7 @@ public void start(String userName) throws IOException {
public void stop() {
if (isRunning()) {
- LOGGER.info("Kill interpreter process");
+ LOGGER.info("Kill interpreter process for interpreter group: " +
getInterpreterGroupId());
Review comment:
We should avoid the creation of objects if a logging level is disabled
This particular line should change to
```
LOGGER.info("Kill interpreter process for interpreter group: {}",
getInterpreterGroupId());
```
String concatenation creates a new String object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
