zjffdu commented on a change in pull request #3795:
URL: https://github.com/apache/zeppelin/pull/3795#discussion_r439979998
##########
File path: flink/flink1.10-shims/pom.xml
##########
@@ -33,7 +33,7 @@
<name>Zeppelin: Flink1.10 Shims</name>
<properties>
- <flink.version>1.10.0</flink.version>
Review comment:
I am afraid not. I plan to add profile flink-1.10 and flink-1.11 for
flink interpreter after flink 1.11 is released. But `flink.version` in
`flink1.10-shims` will not be affected by profile, it should always be flink
1.10, `flink.version` in `flink/interpreter` module will be affected by this
profile, and will run test under `flink/interpreter` for different flink
version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
