alexott commented on a change in pull request #3795:
URL: https://github.com/apache/zeppelin/pull/3795#discussion_r440105223



##########
File path: flink/flink1.10-shims/pom.xml
##########
@@ -33,7 +33,7 @@
     <name>Zeppelin: Flink1.10 Shims</name>
 
     <properties>
-        <flink.version>1.10.0</flink.version>

Review comment:
       I meant, that we can define property, like, `<flink.1.10.version>` and 
refer to it... I did this for Hadoop:
   
   ```
       <hadoop2.7.version>2.7.7</hadoop2.7.version>
       <hadoop2.6.version>2.6.5</hadoop2.6.version>
       <hadoop3.0.version>3.0.3</hadoop3.0.version>
       <hadoop3.1.version>3.1.3</hadoop3.1.version>
   ```
   
   and then use it as `${hadoop3.1.version}`, etc.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to