zjffdu commented on a change in pull request #3825:
URL: https://github.com/apache/zeppelin/pull/3825#discussion_r446013880



##########
File path: zeppelin-plugins/launcher/k8s-standard/pom.xml
##########
@@ -37,21 +37,47 @@
 
     <properties>
         <plugin.name>Launcher/K8sStandardInterpreterLauncher</plugin.name>
+        <version.kubernetes.client>4.10.2</version.kubernetes.client>
     </properties>
 
     <dependencies>
+        <dependency>
+            <groupId>io.fabric8</groupId>
+            <artifactId>kubernetes-client</artifactId>
+            <version>${version.kubernetes.client}</version>

Review comment:
       how about `kubernetes.client.version` ? This is the convention we use 
for other libraries. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to