Leemoonsoo commented on a change in pull request #3825:
URL: https://github.com/apache/zeppelin/pull/3825#discussion_r449235423
##########
File path:
zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcess.java
##########
@@ -240,30 +238,31 @@ void apply(File path, boolean delete) throws IOException {
}
for (File f : files) {
- apply(f, delete);
+ apply(f, delete, templateProperties);
}
} else if (path.isFile()) {
- LOGGER.info("Apply {}", path.getAbsolutePath());
K8sSpecTemplate specTemplate = new K8sSpecTemplate();
- specTemplate.loadProperties(getTemplateBindings());
-
- String spec = specTemplate.render(path);
+ String template = specTemplate.render(path);
+ specTemplate.loadProperties(templateProperties);
Review comment:
Looks like `loadProperties()` should be placed before `render()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
