Leemoonsoo commented on a change in pull request #3825:
URL: https://github.com/apache/zeppelin/pull/3825#discussion_r449690341
##########
File path:
zeppelin-plugins/launcher/k8s-standard/src/main/java/org/apache/zeppelin/interpreter/launcher/K8sRemoteInterpreterProcess.java
##########
@@ -240,30 +238,31 @@ void apply(File path, boolean delete) throws IOException {
}
for (File f : files) {
- apply(f, delete);
+ apply(f, delete, templateProperties);
}
} else if (path.isFile()) {
- LOGGER.info("Apply {}", path.getAbsolutePath());
K8sSpecTemplate specTemplate = new K8sSpecTemplate();
- specTemplate.loadProperties(getTemplateBindings());
-
- String spec = specTemplate.render(path);
+ String template = specTemplate.render(path);
+ specTemplate.loadProperties(templateProperties);
Review comment:
I also didn't recognize this one earlier :) Anyway, I tested this branch
and everything works well on my environment as well. LGTM.
(I think you can [configure merge
script](https://github.com/apache/zeppelin/blob/master/dev/merge_zeppelin_pr.py#L41-L45)
and merge this PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
