conker84 commented on a change in pull request #3851:
URL: https://github.com/apache/zeppelin/pull/3851#discussion_r455063293
##########
File path: neo4j/pom.xml
##########
@@ -65,10 +63,9 @@
</dependency>
<dependency>
- <groupId>org.neo4j.test</groupId>
- <artifactId>neo4j-harness</artifactId>
- <version>${neo4j.version}</version>
- <scope>test</scope>
+ <groupId>org.testcontainers</groupId>
+ <artifactId>neo4j</artifactId>
+ <version>${testcontainers.version}</version>
Review comment:
We need it here because in the parent I only defined the
`testcontainers` artifact:
https://github.com/apache/zeppelin/blob/4f2e95e5c694e2f2e786e9436af41c11a4726204/pom.xml#L921-L926
So every project can import the specific container, in the same way, I did
for the `Neo4jContainer`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]