jongyoul commented on pull request #3851: URL: https://github.com/apache/zeppelin/pull/3851#issuecomment-660602821
Hello, It feels quite difficult to make the rule that which are located in common and particular. I personally like to locate in one place because any dependency can be added in another pom.xml after it’s added in one specific place. it might not be a problem but it can make multiple version issues. We already had the issue related to multiple version and it’s too difficult to solve it. I understand this dependency would be only in Neo4j but I think it would be better to define in common place with the version information and add it on a specific sub module until we decide the exact rule. WDYT? 2020년 7월 19일 (일) 16:22, Alex Ott <[email protected]>님이 작성: > @jongyoul <https://github.com/jongyoul> most of the interpreters define > dependencies that are specific for them in their local pom.xml, like, here > - this artifact is only for Neo4j, and I think it makes no sense to pollute > the top level pom.xml with interpreter-specific dependency. If we want to > enforce that, we need to do this for all interpeters > But It makes sense to have common dependencies moved out... > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/zeppelin/pull/3851#issuecomment-660601344>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AA3R7FU5SANIU3D2OOPZEGLR4KNJ3ANCNFSM4OX6AIVA> > . > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
