zjffdu commented on a change in pull request #3965:
URL: https://github.com/apache/zeppelin/pull/3965#discussion_r519436620
##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -500,53 +502,41 @@ public Connection getConnection(String dbPrefix,
InterpreterContext context)
setUserProperty(dbPrefix, context);
final Properties properties =
jdbcUserConfigurations.getPropertyMap(dbPrefix);
- final String url = properties.getProperty(URL_KEY);
+ String url = properties.getProperty(URL_KEY);
+ String principal = getProperty("zeppelin.jdbc.principal");
Review comment:
It is weird it fails with principal specified, do you have the exact
error message ? IIUC, the principal is required. It should fails if it is not
specified.
##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -500,53 +502,41 @@ public Connection getConnection(String dbPrefix,
InterpreterContext context)
setUserProperty(dbPrefix, context);
final Properties properties =
jdbcUserConfigurations.getPropertyMap(dbPrefix);
- final String url = properties.getProperty(URL_KEY);
+ String url = properties.getProperty(URL_KEY);
+ String principal = getProperty("zeppelin.jdbc.principal");
Review comment:
It is weird it fails with principal specified, do you have the exact
error message ? IIUC, the principal is required. It should fail if it is not
specified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
