zjffdu commented on a change in pull request #3965:
URL: https://github.com/apache/zeppelin/pull/3965#discussion_r520255546



##########
File path: jdbc/src/main/java/org/apache/zeppelin/jdbc/JDBCInterpreter.java
##########
@@ -500,53 +502,41 @@ public Connection getConnection(String dbPrefix, 
InterpreterContext context)
     setUserProperty(dbPrefix, context);
 
     final Properties properties = 
jdbcUserConfigurations.getPropertyMap(dbPrefix);
-    final String url = properties.getProperty(URL_KEY);
+    String url = properties.getProperty(URL_KEY);
+    String principal = getProperty("zeppelin.jdbc.principal");

Review comment:
       Let me revert this change. Originally I just want to remove the 
redundant principal in `default.url`, because we already ask user to specify 
principal in `zeppelin.jdbc.principal`, if hive behaivor changes, it is better 
not to append principal for user




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to