Reamer commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073656877
##########
python/src/test/java/org/apache/zeppelin/python/IPythonInterpreterTest.java:
##########
@@ -434,9 +434,6 @@ public void run() {
InterpreterResult result = interpreter.interpret("import
time\ntime.sleep(1000)",
getInterpreterContext());
waiter.assertEquals(InterpreterResult.Code.ERROR, result.code());
- waiter.assertEquals(
- "IPython kernel is abnormally exited, please check your code
and log.",
- result.message().get(0).getData());
Review Comment:
During my tests `result.message()` was always `null`. We can investigate
this later, as this has nothing to do with the issue.
In the summary of https://github.com/apache/zeppelin/actions/runs/3939354095
you can also see several errors which have errors because of this `null`.
The `0` errors indicate the `null` error:
After clicking on the message, the exception is displayed.
If you then look in the affected line, you will see a similar line.
https://github.com/apache/zeppelin/blob/0209d0d0d40e979bd284d89ec3eb6a90a34bf84a/spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkIRInterpreterTest.java#L110-L128
You should not make assertions within additional threads. See also:
https://rules.sonarsource.com/java/RSPEC-2186
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
