Reamer commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1073665797
##########
zeppelin-zengine/pom.xml:
##########
@@ -304,10 +304,6 @@
</executions>
</plugin>
- <plugin>
Review Comment:
It took me a long time to figure out that this execution breaks the Maven
build.
Until a few hours ago, I thought that this execution was just putting the
dependencies under a location. What I didn't know is that this step also adds
the dependency to the Maven reactor. This has led to various duplicate
libraries within the Maven build, up to and including serious errors. It was
hard to debug because the IDE ignores these dependencies.
The funny or sad thing, the build step is completely unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
