Github user hayssams commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-99041112
You're right, this PR addresses 1) & 2).
Regarding the points you raised
- The login window is useful if we want to support form auth in addition to
the basic auth this PR provides. This may be added in another PR easily with
almost no impact to the current code.
- Right, we need to display the current user. Do you want me to add it at
the top of the note with a logout button ?
- Zeppelin-26 : Did not look at it yet.
- Migration script : that should be easy. to just move existing notes to
the anonymous subdirectory with no impact on the existing code
- Multitenant : Would starting the "interpreter.sh" script with a different
identity solve the problem ?
Actually feature 2) involves a very small amount of code (load/save notes
in user directory).
I am personally interested by feature 2). let me know if you want me to
complete the other points you raised first or if you prefer to stick to feature
1). I'll respect your choice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---