@djoelz - can you clarify the standard you're using to decide when tests are required? I'm putting together tests for the R interpreter PR, and it seems like you have a logical method for determining what has to be testable. If there's documentation on a testing standard for submissions, I'd appreciate if someone pointed me that way.
> On Aug 18, 2015, at 2:40 PM, djoelz <g...@git.apache.org> wrote: > > Github user djoelz commented on the pull request: > > https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-132313144 > > I feel that this needs far more test coverage with all the new public > methods it introduces. Just changing the existing tests is not enough. Please > add unit tests to the methods added/changed in NotebookRestApi > SecurityRestApi > ZeppelinServer > NotebookServer > TicketContainer > Notebook > VFSNotebookRepo > > Also we should think about adding security with interfaces and have this > be an implementation of those interfaces. Thoughts? > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > ---
