Hi Amos! I am going with test driven development <http://agiledata.org/essays/tdd.html> while the process mentions creating a test first I believe that if at the end the test and the code exist then the goal is reached. In general if we change/add public facing methods we must ensure that they continue to work. Creating unit tests for them make it clear what their intention is and protects the project from changes that might change their intention. While the end to end tests of create note help it makes the maintenance of the new added/changed methods more complicated as there is no tests to dictate their purpose.
I like a quote from the link that best describes my intent: If it's worth building, it's worth testing. If it's not worth testing, why are you wasting your time working on it? Let me know if you have any questions, Joel Here are more resources: https://msdn.microsoft.com/en-US/library/Aa730844(v=VS.80).aspx https://en.wikipedia.org/wiki/Test-driven_development On Tue, Aug 18, 2015 at 12:20 PM, Amos B. Elberg <amos.elb...@gmail.com> wrote: > @djoelz - can you clarify the standard you're using to decide when tests > are required? I'm putting together tests for the R interpreter PR, and it > seems like you have a logical method for determining what has to be > testable. If there's documentation on a testing standard for submissions, > I'd appreciate if someone pointed me that way. > > > On Aug 18, 2015, at 2:40 PM, djoelz <g...@git.apache.org> wrote: > > > > Github user djoelz commented on the pull request: > > > > > https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-132313144 > > > > I feel that this needs far more test coverage with all the new public > methods it introduces. Just changing the existing tests is not enough. > Please add unit tests to the methods added/changed in NotebookRestApi > > SecurityRestApi > > ZeppelinServer > > NotebookServer > > TicketContainer > > Notebook > > VFSNotebookRepo > > > > Also we should think about adding security with interfaces and have > this be an implementation of those interfaces. Thoughts? > > > > > > --- > > If your project is set up for it, you can reply to this email and have > your > > reply appear on GitHub as well. If your project does not have this > feature > > enabled and wishes so, or if the feature is enabled but not working, > please > > contact infrastructure at infrastruct...@apache.org or file a JIRA > ticket > > with INFRA. > > --- > -- Dayam Joel Zambrano
