[GitHub] incubator-zeppelin pull request: Added Shiro security

[hayssams]

Github user hayssams commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-133314006
  
    Hello
    Just came back from vacation. Give me a couple of weeks to build the
    required tests.
    
    Cordialement.
    
    *Hayssam Saleh, Architecture & Stratégie S.I.
    *+33 6 85 71 13 95 | LinkedIn Profile
    <http://fr.linkedin.com/pub/hayssam-saleh/0/144/bb8> | ebiznext :)
    <http://www.ebiznext.com> | Skype ID <http://hayssam.saleh2>
    
    
    On Tue, Aug 18, 2015 at 8:40 PM, djoelz <notificati...@github.com> wrote:
    
    > I feel that this needs far more test coverage with all the new public
    > methods it introduces. Just changing the existing tests is not enough.
    > Please add unit tests to the methods added/changed in NotebookRestApi
    > SecurityRestApi
    > ZeppelinServer
    > NotebookServer
    > TicketContainer
    > Notebook
    > VFSNotebookRepo
    >
    > Also we should think about adding security with interfaces and have this
    > be an implementation of those interfaces. Thoughts?
    >
    > —
    > Reply to this email directly or view it on GitHub
    > 
<https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-132313144>
    > .
    >
    
    -- 
    *EBIZNEXT <http://www.ebiznext.com>  Java / .NET **/ DevOps / BigData / UX 
    / Agile*
    23 rue Vernet 75008 Paris 
    <https://maps.google.com/?q=23%20rue%20Vernet%2075008%20Paris>
    
       
    
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---