Code improvements
-----------------
Key: ZOOKEEPER-993
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-993
Project: ZooKeeper
Issue Type: Improvement
Components: leaderElection
Affects Versions: 3.3.2, 3.3.3
Environment: Linux box, Eclipse IDE,
Reporter: MIS
Priority: Minor
Fix For: 3.3.3
In the file org.apache.zookeeper.server.quorum.FastLeaderElection.java for
methods like totalOrderPredicate and termPredicate, which return boolean, the
code is as below :
if (condition)
return true;
else
return false;
I feel, it would be better if the condition itself is returned.
i.e., return condition.
The same thing holds good else where if applicable.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
