[
https://issues.apache.org/jira/browse/ZOOKEEPER-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997304#comment-12997304
]
MIS commented on ZOOKEEPER-993:
-------------------------------
Hi, All
This ticket doesn't alter the existing behavior, but just involves code
refactoring.
As far as the test cases are concerned, a status-quo should be maintained
w.r.t result of test case execution, which is maintained.
I know every patch needs to have test cases included, but in this scenario
will it hold good?
Please let me know in case of any issues, which are blocking this patch from
being committed.
Thanks,
MIS.
> Code improvements
> -----------------
>
> Key: ZOOKEEPER-993
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-993
> Project: ZooKeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.3.2, 3.3.3
> Environment: Linux box, Eclipse IDE,
> Reporter: MIS
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-993-patch.txt
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In the file org.apache.zookeeper.server.quorum.FastLeaderElection.java for
> methods like totalOrderPredicate and termPredicate, which return boolean, the
> code is as below :
> if (condition)
> return true;
> else
> return false;
> I feel, it would be better if the condition itself is returned.
> i.e., return condition.
> The same thing holds good else where if applicable.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
