Hi, All This ticket doesn't alter the existing behavior, but just involves code refactoring. As far as the test cases are concerned, a status-quo should be maintained w.r.t result of test case execution, which is maintained.
I know every patch needs to have test cases included, but in this scenario will it hold good? Please let me know in case of any issues, which are blocking this patch from being committed. Thanks, MIS. On Sat, Feb 19, 2011 at 1:21 PM, Hadoop QA (JIRA) <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/ZOOKEEPER-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12996719#comment-12996719] > > Hadoop QA commented on ZOOKEEPER-993: > ------------------------------------- > > -1 overall. Here are the results of testing the latest attachment > > http://issues.apache.org/jira/secure/attachment/12471309/ZOOKEEPER-993-patch.txt > against trunk revision 1072085. > > +1 @author. The patch does not contain any @author tags. > > -1 tests included. The patch doesn't appear to include any new or > modified tests. > Please justify why no new tests are needed for this > patch. > Also please list what manual steps were performed to > verify this patch. > > +1 javadoc. The javadoc tool did not generate any warning messages. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 findbugs. The patch does not introduce any new Findbugs (version > 1.3.9) warnings. > > +1 release audit. The applied patch does not increase the total number > of release audit warnings. > > -1 core tests. The patch failed core unit tests. > > +1 contrib tests. The patch passed contrib unit tests. > > Test results: > https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/140//testReport/ > Findbugs warnings: > https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/140//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html > Console output: > https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/140//console > > This message is automatically generated. > > > Code improvements > > ----------------- > > > > Key: ZOOKEEPER-993 > > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-993 > > Project: ZooKeeper > > Issue Type: Improvement > > Components: leaderElection > > Affects Versions: 3.3.2, 3.3.3 > > Environment: Linux box, Eclipse IDE, > > Reporter: MIS > > Priority: Minor > > Fix For: 3.4.0 > > > > Attachments: ZOOKEEPER-993-patch.txt > > > > Original Estimate: 0.5h > > Remaining Estimate: 0.5h > > > > In the file org.apache.zookeeper.server.quorum.FastLeaderElection.java > for methods like totalOrderPredicate and termPredicate, which return > boolean, the code is as below : > > if (condition) > > return true; > > else > > return false; > > I feel, it would be better if the condition itself is returned. > > i.e., return condition. > > The same thing holds good else where if applicable. > > -- > This message is automatically generated by JIRA. > - > For more information on JIRA, see: http://www.atlassian.com/software/jira > > >
