[
https://issues.apache.org/jira/browse/ZOOKEEPER-993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007885#comment-13007885
]
Hudson commented on ZOOKEEPER-993:
----------------------------------
Integrated in ZooKeeper-trunk #1124 (See
[https://hudson.apache.org/hudson/job/ZooKeeper-trunk/1124/])
ZOOKEEPER-993. Code improvements (MIS via fpj)
> Code improvements
> -----------------
>
> Key: ZOOKEEPER-993
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-993
> Project: ZooKeeper
> Issue Type: Improvement
> Components: leaderElection
> Affects Versions: 3.3.2, 3.3.3
> Environment: Linux box, Eclipse IDE,
> Reporter: MIS
> Assignee: MIS
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-993-patch.txt
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> In the file org.apache.zookeeper.server.quorum.FastLeaderElection.java for
> methods like totalOrderPredicate and termPredicate, which return boolean, the
> code is as below :
> if (condition)
> return true;
> else
> return false;
> I feel, it would be better if the condition itself is returned.
> i.e., return condition.
> The same thing holds good else where if applicable.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
