[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069674#comment-13069674
 ] 

[email protected] commented on ZOOKEEPER-999:
---------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1143/#review1169
-----------------------------------------------------------


The packaging code itself looks pretty good now. I've moved on to verifying the 
installation, however I see issues installing the deb on a clean ubuntu 10.10. 
Can you try generating the packages, install them and work through these? (ie 
test on ubuntu and rhel/centos).

1) the following during install:

Setting up zookeeper (3.4.0) ...
ln: creating symbolic link `/usr/etc/zookeeper': No such file or directory

2) I'm unable to start the server, seems like number of issues: a) why 
/usr/sbin/../etc/zookeeper for config, should just be /etc/zookeeper no? b) 
permission issues, notice I am running this as sudo.

sudo /etc/init.d/zookeeper start
 * Starting Apache ZooKeeper server zookeeper                                   
                  JMX enabled by default
Using config: /usr/sbin/../etc/zookeeper/zoo.cfg
grep: /usr/sbin/../etc/zookeeper/zoo.cfg: No such file or directory
mkdir: cannot create directory `': No such file or directory
Starting zookeeper ... /usr/bin/../sbin/zkServer.sh: line 109: 
/zookeeper_server.pid: Permission denied
FAILED TO WRITE PID
/usr/bin/../sbin/zkServer.sh: line 105: ./zookeeper.out: Permission denied
                                                                                
           [fail]



./src/packages/deb/zookeeper.control/control
<https://reviews.apache.org/r/1143/#comment2429>

    should we depend on either the jre or the jdk?



./README_packaging.txt
<https://reviews.apache.org/r/1143/#comment2435>

    Nice!
    
    Would be nice to add - when I build where are the generated deb/rpm files 
placed?
    
    Are there any requirements for building? (I don't think so, but I'm not 
sure)



./README_packaging.txt
<https://reviews.apache.org/r/1143/#comment2437>

    It's great to document the source layout, could we also provide some detail 
on where things are placed on the install machine? (high level is fine).



./src/contrib/zkpython/src/packages/deb/zkpython.control/control
<https://reviews.apache.org/r/1143/#comment2431>

    missing license - is there a way to add comments here or no?



./src/packages/deb/zookeeper.control/conffile
<https://reviews.apache.org/r/1143/#comment2432>

    license?



./src/packages/templates/conf/zookeeper-env.sh
<https://reviews.apache.org/r/1143/#comment2433>

    need license header here.


- Patrick


On 2011-07-22 18:24:20, Patrick Hunt wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1143/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-22 18:24:20)
bq.  
bq.  
bq.  Review request for zookeeper and Mahadev Konar.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This goal of this ticket is to generate a set of RPM/debian package which 
integrate well with RPM sets created by HADOOP-6255.
bq.  
bq.  
bq.  This addresses bug ZOOKEEPER-999.
bq.      https://issues.apache.org/jira/browse/ZOOKEEPER-999
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    ./README_packaging.txt PRE-CREATION 
bq.    ./bin/zkCleanup.sh 1148587 
bq.    ./bin/zkCli.sh 1148587 
bq.    ./bin/zkEnv.sh 1148587 
bq.    ./bin/zkServer.sh 1148587 
bq.    ./build.xml 1148587 
bq.    ./ivy.xml 1148587 
bq.    ./src/contrib/build-contrib.xml 1148587 
bq.    ./src/contrib/build.xml 1148587 
bq.    ./src/contrib/zkpython/build.xml 1148587 
bq.    ./src/contrib/zkpython/ivy.xml PRE-CREATION 
bq.    ./src/contrib/zkpython/src/packages/deb/zkpython.control/control 
PRE-CREATION 
bq.    ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION 
bq.    ./src/contrib/zkpython/src/python/setup.py 1148587 
bq.    ./src/packages/deb/init.d/zookeeper PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/conffile PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/control PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/postinst PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/postrm PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/preinst PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/prerm PRE-CREATION 
bq.    ./src/packages/rpm/init.d/zookeeper PRE-CREATION 
bq.    ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION 
bq.    ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION 
bq.    ./src/packages/update-zookeeper-env.sh PRE-CREATION 
bq.    ./src/recipes/build-recipes.xml 1148587 
bq.    ./src/recipes/build.xml 1148587 
bq.    ./src/recipes/lock/build.xml 1148587 
bq.    ./src/recipes/queue/build.xml 1148587 
bq.  
bq.  Diff: https://reviews.apache.org/r/1143/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Patrick
bq.  
bq.



> Create an package integration project
> -------------------------------------
>
>                 Key: ZOOKEEPER-999
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-999
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: build
>         Environment: Java 6, RHEL/Ubuntu
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-999-1.patch, ZOOKEEPER-999-2.patch, 
> ZOOKEEPER-999-3.patch, ZOOKEEPER-999-4.patch, ZOOKEEPER-999-5.patch, 
> ZOOKEEPER-999-6.patch, ZOOKEEPER-999-7.patch, ZOOKEEPER-999-8.patch, 
> ZOOKEEPER-999.patch
>
>
> This goal of this ticket is to generate a set of RPM/debian package which 
> integrate well with RPM sets created by HADOOP-6255.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to