[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070569#comment-13070569
 ] 

[email protected] commented on ZOOKEEPER-999:
---------------------------------------------------------



bq.  On 2011-07-21 06:02:33, Patrick Hunt wrote:
bq.  > I ran "ant deb" successfully, although I have not yet tried to install 
it. I noticed a couple issues with the generated package.
bq.  > 
bq.  > shouldn't /etc/zookeeper contain zoo.cfg?
bq.  > 
bq.  > drwxr-xr-x 0/0               0 2011-07-20 22:41 ./etc/
bq.  > drwxr-xr-x 0/0               0 2011-07-20 22:41 ./etc/zookeeper/
bq.  > -rw-r--r-- 0/0             535 2011-07-20 22:41 
./etc/zookeeper/configuration.xsl
bq.  > -rw-r--r-- 0/0            2161 2011-07-20 22:41 
./etc/zookeeper/log4j.properties
bq.  > -rw-r--r-- 0/0             447 2011-07-20 22:41 
./etc/zookeeper/zoo_sample.cfg
bq.  > 
bq.  > shouldn't we be creating (if doesn't exist) the /var/lib/zookeeper 
directory? ZK does this currently, however I'm planning to file a bug for this 
- really we shouldn't come up if we can't find this directory (handles case of 
misconfiguration - we stop rather than start with an empty data hierarchy)
bq.  > 
bq.  > Can you add some documentation? Nothing fancy, perhaps a 
README_packaging.txt at the toplevel that describes the currently supported 
packages, some basic information about them, how to build "ant deb" etc..., 
additional requirements to build, etc... something basic to help out someone 
trying to build the packages.

The system should generate zoo.cfg, if it doesn't exist.  It looks like a bug.  
I will look into it.  I will add README_packaging.txt in the next patch.  Same 
for sun jdk.


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1143/#review1149
-----------------------------------------------------------


On 2011-07-22 18:24:20, Patrick Hunt wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1143/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-22 18:24:20)
bq.  
bq.  
bq.  Review request for zookeeper and Mahadev Konar.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This goal of this ticket is to generate a set of RPM/debian package which 
integrate well with RPM sets created by HADOOP-6255.
bq.  
bq.  
bq.  This addresses bug ZOOKEEPER-999.
bq.      https://issues.apache.org/jira/browse/ZOOKEEPER-999
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    ./README_packaging.txt PRE-CREATION 
bq.    ./bin/zkCleanup.sh 1148587 
bq.    ./bin/zkCli.sh 1148587 
bq.    ./bin/zkEnv.sh 1148587 
bq.    ./bin/zkServer.sh 1148587 
bq.    ./build.xml 1148587 
bq.    ./ivy.xml 1148587 
bq.    ./src/contrib/build-contrib.xml 1148587 
bq.    ./src/contrib/build.xml 1148587 
bq.    ./src/contrib/zkpython/build.xml 1148587 
bq.    ./src/contrib/zkpython/ivy.xml PRE-CREATION 
bq.    ./src/contrib/zkpython/src/packages/deb/zkpython.control/control 
PRE-CREATION 
bq.    ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION 
bq.    ./src/contrib/zkpython/src/python/setup.py 1148587 
bq.    ./src/packages/deb/init.d/zookeeper PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/conffile PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/control PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/postinst PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/postrm PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/preinst PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/prerm PRE-CREATION 
bq.    ./src/packages/rpm/init.d/zookeeper PRE-CREATION 
bq.    ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION 
bq.    ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION 
bq.    ./src/packages/update-zookeeper-env.sh PRE-CREATION 
bq.    ./src/recipes/build-recipes.xml 1148587 
bq.    ./src/recipes/build.xml 1148587 
bq.    ./src/recipes/lock/build.xml 1148587 
bq.    ./src/recipes/queue/build.xml 1148587 
bq.  
bq.  Diff: https://reviews.apache.org/r/1143/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Patrick
bq.  
bq.



> Create an package integration project
> -------------------------------------
>
>                 Key: ZOOKEEPER-999
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-999
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: build
>         Environment: Java 6, RHEL/Ubuntu
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-999-1.patch, ZOOKEEPER-999-2.patch, 
> ZOOKEEPER-999-3.patch, ZOOKEEPER-999-4.patch, ZOOKEEPER-999-5.patch, 
> ZOOKEEPER-999-6.patch, ZOOKEEPER-999-7.patch, ZOOKEEPER-999-8.patch, 
> ZOOKEEPER-999-9.patch, ZOOKEEPER-999.patch
>
>
> This goal of this ticket is to generate a set of RPM/debian package which 
> integrate well with RPM sets created by HADOOP-6255.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to