[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070568#comment-13070568
 ] 

[email protected] commented on ZOOKEEPER-999:
---------------------------------------------------------



bq.  On 2011-07-22 18:50:04, Patrick Hunt wrote:
bq.  > ./src/contrib/zkpython/src/packages/deb/zkpython.control/control, line 1
bq.  > <https://reviews.apache.org/r/1143/diff/4/?file=26885#file26885line1>
bq.  >
bq.  >     missing license - is there a way to add comments here or no?
bq.  
bq.  Eric Yang wrote:
bq.      Will do.

I did, ZOOKEEPER-999-9.patch shows the license, but for some reason review 
board isn't picking up the additions.


bq.  On 2011-07-22 18:50:04, Patrick Hunt wrote:
bq.  > ./README_packaging.txt, line 1
bq.  > <https://reviews.apache.org/r/1143/diff/4/?file=26874#file26874line1>
bq.  >
bq.  >     Nice!
bq.  >     
bq.  >     Would be nice to add - when I build where are the generated deb/rpm 
files placed?
bq.  >     
bq.  >     Are there any requirements for building? (I don't think so, but I'm 
not sure)
bq.  
bq.  Eric Yang wrote:
bq.      cppunit, and python-setuptools are required.  Will include those in 
README_packaging.txt.
bq.  
bq.  Patrick Hunt wrote:
bq.      well those are required to build zk itself. you probably shouldn't add 
that, I was just thinking if anything pkging related was required.

For rpm, it will require RHEL or CentOS because it depends on rpmbuild.  Debian 
build is base on java plugin, hence it can build on both RHEL or Ubuntu.


bq.  On 2011-07-22 18:50:04, Patrick Hunt wrote:
bq.  > ./src/packages/deb/zookeeper.control/control, line 6
bq.  > <https://reviews.apache.org/r/1143/diff/3-4/?file=26615#file26615line6>
bq.  >
bq.  >     should we depend on either the jre or the jdk?
bq.  
bq.  Eric Yang wrote:
bq.      I have no problem using ZooKeeper with only JRE installed.
bq.  
bq.  Patrick Hunt wrote:
bq.      yes, that's fine, my point is that someone else may only have the jdk 
installed, shouldn't they be able to run w/o installing jre (on ubuntu at least 
there is no dependency btw jre/jdk afaict).

I just tested installing sun-java6-jdk without jre on Ubuntu 11.04.  It doesn't 
let me install.  I think the dependency is right.


- Eric


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1143/#review1169
-----------------------------------------------------------


On 2011-07-22 18:24:20, Patrick Hunt wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/1143/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-07-22 18:24:20)
bq.  
bq.  
bq.  Review request for zookeeper and Mahadev Konar.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This goal of this ticket is to generate a set of RPM/debian package which 
integrate well with RPM sets created by HADOOP-6255.
bq.  
bq.  
bq.  This addresses bug ZOOKEEPER-999.
bq.      https://issues.apache.org/jira/browse/ZOOKEEPER-999
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    ./README_packaging.txt PRE-CREATION 
bq.    ./bin/zkCleanup.sh 1148587 
bq.    ./bin/zkCli.sh 1148587 
bq.    ./bin/zkEnv.sh 1148587 
bq.    ./bin/zkServer.sh 1148587 
bq.    ./build.xml 1148587 
bq.    ./ivy.xml 1148587 
bq.    ./src/contrib/build-contrib.xml 1148587 
bq.    ./src/contrib/build.xml 1148587 
bq.    ./src/contrib/zkpython/build.xml 1148587 
bq.    ./src/contrib/zkpython/ivy.xml PRE-CREATION 
bq.    ./src/contrib/zkpython/src/packages/deb/zkpython.control/control 
PRE-CREATION 
bq.    ./src/contrib/zkpython/src/packages/rpm/spec/zkpython.spec PRE-CREATION 
bq.    ./src/contrib/zkpython/src/python/setup.py 1148587 
bq.    ./src/packages/deb/init.d/zookeeper PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/conffile PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/control PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/postinst PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/postrm PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/preinst PRE-CREATION 
bq.    ./src/packages/deb/zookeeper.control/prerm PRE-CREATION 
bq.    ./src/packages/rpm/init.d/zookeeper PRE-CREATION 
bq.    ./src/packages/rpm/spec/zookeeper.spec PRE-CREATION 
bq.    ./src/packages/templates/conf/zookeeper-env.sh PRE-CREATION 
bq.    ./src/packages/update-zookeeper-env.sh PRE-CREATION 
bq.    ./src/recipes/build-recipes.xml 1148587 
bq.    ./src/recipes/build.xml 1148587 
bq.    ./src/recipes/lock/build.xml 1148587 
bq.    ./src/recipes/queue/build.xml 1148587 
bq.  
bq.  Diff: https://reviews.apache.org/r/1143/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Patrick
bq.  
bq.



> Create an package integration project
> -------------------------------------
>
>                 Key: ZOOKEEPER-999
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-999
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: build
>         Environment: Java 6, RHEL/Ubuntu
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-999-1.patch, ZOOKEEPER-999-2.patch, 
> ZOOKEEPER-999-3.patch, ZOOKEEPER-999-4.patch, ZOOKEEPER-999-5.patch, 
> ZOOKEEPER-999-6.patch, ZOOKEEPER-999-7.patch, ZOOKEEPER-999-8.patch, 
> ZOOKEEPER-999-9.patch, ZOOKEEPER-999.patch
>
>
> This goal of this ticket is to generate a set of RPM/debian package which 
> integrate well with RPM sets created by HADOOP-6255.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to