[
https://issues.apache.org/jira/browse/ZOOKEEPER-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114753#comment-13114753
]
Hadoop QA commented on ZOOKEEPER-1204:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12496489/ZOOKEEPER-1204.patch
against trunk revision 1173949.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/589//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/589//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/589//console
This message is automatically generated.
> Shorten calls to ZooTrace
> -------------------------
>
> Key: ZOOKEEPER-1204
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1204
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Thomas Koch
> Assignee: Thomas Koch
> Attachments: ZOOKEEPER-1204.patch
>
>
> The calls to ZooTrace are kind of verbose and contain duplicated logic. This
> patch makes the calls as short as possible so that they do not distract that
> much from what's actually going on.
> Calls to LOG.isTraceEnabled() are removed at many places, because this check
> is done anyways inside ZooTracer. At some places it has been left, to avoid
> costly message creation.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
