[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128486#comment-13128486
 ] 

[email protected] commented on ZOOKEEPER-1204:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2045/
-----------------------------------------------------------

(Updated 2011-10-16 19:05:48.308818)


Review request for zookeeper.


Summary
-------


                
> Shorten calls to ZooTrace
> -------------------------
>
>                 Key: ZOOKEEPER-1204
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1204
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>         Attachments: ZOOKEEPER-1204.patch, ZOOKEEPER-1204.patch
>
>
> The calls to ZooTrace are kind of verbose and contain duplicated logic. This 
> patch makes the calls as short as possible so that they do not distract that 
> much from what's actually going on.
> Calls to LOG.isTraceEnabled() are removed at many places, because this check 
> is done anyways inside ZooTracer. At some places it has been left, to avoid 
> costly message creation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to