[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131894#comment-13131894
 ] 

Patrick Hunt commented on ZOOKEEPER-1204:
-----------------------------------------

ZooTrace is an artifact of version 1 days (before even log4j was used).

Rather than refactor around zootrace why don't we entirely remove the zoo trace 
facility (I don't know of anyone ever using it) and replace with traditional 
slf4j trace logging.

You want to do that as a separate patch, or just do it here?

                
> Shorten calls to ZooTrace
> -------------------------
>
>                 Key: ZOOKEEPER-1204
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1204
>             Project: ZooKeeper
>          Issue Type: Sub-task
>            Reporter: Thomas Koch
>            Assignee: Thomas Koch
>         Attachments: ZOOKEEPER-1204.patch, ZOOKEEPER-1204.patch
>
>
> The calls to ZooTrace are kind of verbose and contain duplicated logic. This 
> patch makes the calls as short as possible so that they do not distract that 
> much from what's actually going on.
> Calls to LOG.isTraceEnabled() are removed at many places, because this check 
> is done anyways inside ZooTracer. At some places it has been left, to avoid 
> costly message creation.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to