> On Aug. 9, 2014, 3:06 p.m., Alexander Shraer wrote:
> > One consequence of the current implementation is that the user doesn't have
> > control over the name of the dynamic file.
> > if I start zookeeper and name my static file "static.file" and my dynamic
> > file "dynamic.file"
> > then after the server starts up the new dynamic file will be called
> > "static.file.dynamic.10000" and not "dynamic.file.10000".
> >
> > What do you think ?
> >
> > If you leave the current implementation as is, then it seems like
> > QuorumPeer.dynamicConfigFilename
> > is no longer used. If so shouldn't we remove it completely ?
> >
> >
> >
> >
>
> Hongchao Deng wrote:
> Thanks for comments.
>
> So either one sounds good to me.
> I will try to work out something based on dynamic file name
> ("dynamic.file.10000").
>
> So one question is that should dynamic.next file be static or based on
> dynamic file name?
> The latter one could help detect corner case like "null.next" but former
> one is safer.
After a second thought, it might be better to use predefined
"zoo.cfg.dynamic.1000" because this eliminates possible bad path name (too
long, maybe?).
I don't think users will be affected that much for the using a different name.
- Hongchao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24208/#review50113
-----------------------------------------------------------
On Aug. 8, 2014, 2:54 p.m., Hongchao Deng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24208/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 2:54 p.m.)
>
>
> Review request for zookeeper.
>
>
> Repository: zookeeper-git
>
>
> Description
> -------
>
> ZOOKEEPER-1994
>
>
> Diffs
> -----
>
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 76f0afc
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
> c4397a1
> src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java
> 0a8a45a
> src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
> 89416ca
> src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java
> PRE-CREATION
> src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java
> c05aa1b
> src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java
> 1a090dc
>
> Diff: https://reviews.apache.org/r/24208/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hongchao Deng
>
>
