----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24208/#review50250 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java <https://reviews.apache.org/r/24208/#comment87910> nits about style: * space between if and ( * if statements always have {} in their body (i.e.: if (cond) { }) src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java <https://reviews.apache.org/r/24208/#comment87913> nit: spaces between if and ( and in the cond src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java <https://reviews.apache.org/r/24208/#comment87915> ditto src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java <https://reviews.apache.org/r/24208/#comment87916> ditto src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java <https://reviews.apache.org/r/24208/#comment87917> ditto src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java <https://reviews.apache.org/r/24208/#comment87919> no need for the surround ()s - Raul Gutierrez Segales On Aug. 8, 2014, 2:54 p.m., Hongchao Deng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24208/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2014, 2:54 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper-git > > > Description > ------- > > ZOOKEEPER-1994 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 76f0afc > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java > c4397a1 > src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java > 0a8a45a > src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java > 89416ca > src/java/test/org/apache/zookeeper/server/quorum/ReconfigBackupTest.java > PRE-CREATION > src/java/test/org/apache/zookeeper/server/quorum/ReconfigLegacyTest.java > c05aa1b > src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java > 1a090dc > > Diff: https://reviews.apache.org/r/24208/diff/ > > > Testing > ------- > > > Thanks, > > Hongchao Deng > >
