----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26437/#review55875 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java <https://reviews.apache.org/r/26437/#comment96245> Nit: this method name is weird... maybe just getOutstandingChange or even if too long getOutstandingChangeForPath is better i think. src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java <https://reviews.apache.org/r/26437/#comment96246> nit: *existing src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java <https://reviews.apache.org/r/26437/#comment96247> nit: *for paths src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java <https://reviews.apache.org/r/26437/#comment96248> nit: existing src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java <https://reviews.apache.org/r/26437/#comment96249> nit: drop this line src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java <https://reviews.apache.org/r/26437/#comment96250> nit: ditto src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java <https://reviews.apache.org/r/26437/#comment96252> nit: i would drop the the 'expected exception' comments... the intent is clear. src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java <https://reviews.apache.org/r/26437/#comment96251> why? - Raul Gutierrez Segales On Oct. 8, 2014, 6:33 p.m., Hongchao Deng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26437/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 6:33 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper-git > > > Description > ------- > > ZooKeeper-2052 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 8542790 > src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java > 8caf419 > src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b5 > src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java a573180 > > Diff: https://reviews.apache.org/r/26437/diff/ > > > Testing > ------- > > > Thanks, > > Hongchao Deng > >
