> On Oct. 8, 2014, 9:06 p.m., Raul Gutierrez Segales wrote:
> > src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java, line 269
> > <https://reviews.apache.org/r/26437/diff/4/?file=715636#file715636line269>
> >
> >     why?

The test might be flaky without this sleep: epheZk closed, process closeSession 
request; meanwhile zk send a getData request.
My intention is not to make this test flaky. What do you think?


- Hongchao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26437/#review55875
-----------------------------------------------------------


On Oct. 8, 2014, 6:33 p.m., Hongchao Deng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26437/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2014, 6:33 p.m.)
> 
> 
> Review request for zookeeper.
> 
> 
> Repository: zookeeper-git
> 
> 
> Description
> -------
> 
> ZooKeeper-2052
> 
> 
> Diffs
> -----
> 
>   src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 8542790 
>   src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java 
> 8caf419 
>   src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b5 
>   src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java a573180 
> 
> Diff: https://reviews.apache.org/r/26437/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hongchao Deng
> 
>

Reply via email to