----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26437/#review56665 -----------------------------------------------------------
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java <https://reviews.apache.org/r/26437/#comment97075> Just a minor suggestion, can we simply return it like. synchronized (zks.outstandingChanges) { return zks.outstandingChangesForPath.get(path); } src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java <https://reviews.apache.org/r/26437/#comment97069> Just a suggestion. Please add null checks for zks and servcnxnf. In case of any failures it may give NPE and create confusions. src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java <https://reviews.apache.org/r/26437/#comment97074> Removed the assertion, I understood the reason now many are using the MyRequestProcessor. But its good to retain the MARSHALLINGERROR code verification which is used by 'testPRequest' case. One idea is to create a separate MyRequestProcessor1 for this testcase or if you have any better idea, always welcome. src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java <https://reviews.apache.org/r/26437/#comment97076> Instead of sleeping and checking the znode existence, can we modify by watching the ephemral znode deletion and then do multi execution ? - Rakesh R On Oct. 8, 2014, 9:18 p.m., Hongchao Deng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26437/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2014, 9:18 p.m.) > > > Review request for zookeeper. > > > Repository: zookeeper-git > > > Description > ------- > > ZooKeeper-2052 > > > Diffs > ----- > > src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 8542790 > src/java/test/org/apache/zookeeper/server/PrepRequestProcessorTest.java > 8caf419 > src/java/test/org/apache/zookeeper/test/ClientBase.java a6229b5 > src/java/test/org/apache/zookeeper/test/MultiTransactionTest.java a573180 > > Diff: https://reviews.apache.org/r/26437/diff/ > > > Testing > ------- > > > Thanks, > > Hongchao Deng > >
