[
https://issues.apache.org/jira/browse/ZOOKEEPER-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188724#comment-14188724
]
Hadoop QA commented on ZOOKEEPER-2072:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12677932/ZOOKEEPER-2072.patch
against trunk revision 1634776.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2406//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2406//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/2406//console
This message is automatically generated.
> Netty Server Should Configure Child Channel Pipeline By Specifying
> ChannelPipelineFactory
> -----------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2072
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2072
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Attachments: ZOOKEEPER-2072.patch, ZOOKEEPER-2072.patch,
> test-jenkins.patch
>
>
> Currently, netty server is setting up child channel in this way:
> {code}
> bootstrap.getPipeline().addLast("servercnxnfactory", channelHandler);
> {code}
> According to the [netty
> doc|http://netty.io/3.9/api/org/jboss/netty/bootstrap/ServerBootstrap.html],
> bq. you cannot use this approach if you are going to open more than one
> Channels or run a server that accepts incoming connections to create its
> child channels.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
