[
https://issues.apache.org/jira/browse/ZOOKEEPER-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203515#comment-14203515
]
Flavio Junqueira commented on ZOOKEEPER-2069:
---------------------------------------------
[~hdeng], thanks for updating the patch. Your justification for creating a
channel factory upon every connect doesn't make a lot of sense to me, though.
The sendPacket method propagates up already IOException so I don't understand
why it is a problem if you get a closed channel; such exceptions are expected.
> Netty Support for ClientCnxnSocket
> ----------------------------------
>
> Key: ZOOKEEPER-2069
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2069
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Attachments: QA-run-nettyclient-for-test.patch,
> ZOOKEEPER-2069-v2.patch, ZOOKEEPER-2069-v3.patch, ZOOKEEPER-2069-v4.patch,
> ZOOKEEPER-2069-v5.patch, ZOOKEEPER-2069-v6.patch, ZOOKEEPER-2069-v7.patch,
> ZOOKEEPER-2069-v8.patch, ZOOKEEPER-2069-v9.1.patch,
> ZOOKEEPER-2069-v9.2.patch, ZOOKEEPER-2069-v9.patch, ZOOKEEPER-2069.patch,
> draft.patch
>
>
> Review Board: https://reviews.apache.org/r/27244/diff/#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
