[
https://issues.apache.org/jira/browse/ZOOKEEPER-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14247374#comment-14247374
]
Flavio Junqueira commented on ZOOKEEPER-2069:
---------------------------------------------
I actually hadn't realized that the diff revision slider has two cursors, so
you can actually arbitrarily select two revisions and see the changes between
them... cool!
I'm fine with the findbugs exclusion rules. Just to make sure we are on the
same page, your observation 2 relies on the fact that cleanup and doTransport
can't be called concurrently, yes? And, the synchronized block in cleanup is to
guarantee mutual exclusion between cleanup and queuePacket.
> Netty Support for ClientCnxnSocket
> ----------------------------------
>
> Key: ZOOKEEPER-2069
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2069
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Attachments: QA-run-nettyclient-for-test.patch,
> ZOOKEEPER-2069-v10-channel.patch, ZOOKEEPER-2069-v11.patch,
> ZOOKEEPER-2069-v12.patch, ZOOKEEPER-2069-v14.patch,
> ZOOKEEPER-2069-v15-jdk6.patch, ZOOKEEPER-2069-v15-jdk6.patch,
> ZOOKEEPER-2069-v16.patch, ZOOKEEPER-2069-v2.patch, ZOOKEEPER-2069-v3.patch,
> ZOOKEEPER-2069-v4.patch, ZOOKEEPER-2069-v5.patch, ZOOKEEPER-2069-v6.patch,
> ZOOKEEPER-2069-v7.patch, ZOOKEEPER-2069-v8.patch, ZOOKEEPER-2069-v9.1.patch,
> ZOOKEEPER-2069-v9.2.patch, ZOOKEEPER-2069-v9.patch, ZOOKEEPER-2069.patch,
> draft.patch
>
>
> Review Board: https://reviews.apache.org/r/27244/diff/#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
