[
https://issues.apache.org/jira/browse/ZOOKEEPER-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245669#comment-14245669
]
Hongchao Deng commented on ZOOKEEPER-2069:
------------------------------------------
Hi [~fpj]. Sorry for the late response.
1. There is a way to check changes from previous revision.
In RB: under each "Review request changed", there is a "Show changes" link.
If you are more comfortable with Github, I have actually created a [local
PR|https://github.com/fengjingchao/zookeeper/pull/1] for myself. You can view
the commits there to see relevant changes. Except the last commit "use netty"
that I do it for my local Jenkins job.
2. What changes did I make this time?
I changed
{code}
for (Packet p : outgoingQueue) {
conLossPacket(p);
}
outgoingQueue.clear();
{code}
to
{code}
Iterator<Packet> iter = outgoingQueue.iterator();
while (iter.hasNext()) {
Packet p = iter.next();
conLossPacket(p);
iter.remove();
}
{code}
I missed a case that between iterating and clearing there is race.
Thanks for your attention too!!
> Netty Support for ClientCnxnSocket
> ----------------------------------
>
> Key: ZOOKEEPER-2069
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2069
> Project: ZooKeeper
> Issue Type: Sub-task
> Reporter: Hongchao Deng
> Assignee: Hongchao Deng
> Attachments: QA-run-nettyclient-for-test.patch,
> ZOOKEEPER-2069-v10-channel.patch, ZOOKEEPER-2069-v11.patch,
> ZOOKEEPER-2069-v12.patch, ZOOKEEPER-2069-v14.patch,
> ZOOKEEPER-2069-v15-jdk6.patch, ZOOKEEPER-2069-v15-jdk6.patch,
> ZOOKEEPER-2069-v16.patch, ZOOKEEPER-2069-v2.patch, ZOOKEEPER-2069-v3.patch,
> ZOOKEEPER-2069-v4.patch, ZOOKEEPER-2069-v5.patch, ZOOKEEPER-2069-v6.patch,
> ZOOKEEPER-2069-v7.patch, ZOOKEEPER-2069-v8.patch, ZOOKEEPER-2069-v9.1.patch,
> ZOOKEEPER-2069-v9.2.patch, ZOOKEEPER-2069-v9.patch, ZOOKEEPER-2069.patch,
> draft.patch
>
>
> Review Board: https://reviews.apache.org/r/27244/diff/#
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
